Skip to content

Rust: Add telemtry tags to queries #21303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hvitved merged 1 commit into from
Feb 10, 2026
Merged

Rust: Add telemtry tags to queries #21303

hvitved merged 1 commit into from
Feb 10, 2026
+4 −4

Conversation

@hvitved
Copy link
Contributor

@hvitved hvitved commented Feb 10, 2026 •
edited
Loading

Before this PR, each scan would end with a summary like

|                            Metric                            |    Value     |
+--------------------------------------------------------------+--------------+
| Total number of Rust files that were extracted without error |           50 |
| Summary Statistics                                           | (28 results) |
| Nodes With Type At Length Limit                              |            4 |
| Summary Statistics Reduced                                   | (16 results) |
| Total number of Rust files that were extracted with errors   |            0 |
| Query Sink Counts                                            |  (5 results) |

Now, it instead ends with

|                            Metric                            | Value |
+--------------------------------------------------------------+-------+
| Total number of Rust files that were extracted without error |    50 |
| Total number of Rust files that were extracted with errors   |     0 |

I don't think the removed rows provide any relevant information, hence this PR. I'm unsure, though, whether this will break something in the tool status page?

@github-actions github-actions bot added the Rust Pull requests that update Rust code label Feb 10, 2026
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Feb 10, 2026
@hvitved hvitved marked this pull request as ready for review February 10, 2026 11:58
@hvitved hvitved requested a review from a team as a code owner February 10, 2026 11:58
@hvitved hvitved requested review from Copilot and geoffw0 February 10, 2026 11:58
Copilot AI reviewed Feb 10, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts metadata on several Rust “summary” metric queries so they’re additionally tagged as telemetry, which (per the PR description) reduces what appears in the end-of-scan summary table.

Changes:

  • Add the telemetry tag to rust/summary/summary-statistics.
  • Add the telemetry tag to rust/summary/reduced-summary-statistics.
  • Add the telemetry tag to rust/summary/query-sink-counts and rust/summary/nodes-at-type-path-length-limit.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
rust/ql/src/queries/summary/SummaryStatsReduced.ql Adds telemetry to the query tags.
rust/ql/src/queries/summary/SummaryStats.ql Adds telemetry to the query tags.
rust/ql/src/queries/summary/QuerySinkCounts.ql Adds telemetry to the query tags.
rust/ql/src/queries/summary/NodesWithTypeAtLengthLimit.ql Adds telemetry to the query tags.

geoffw0
geoffw0 approved these changes Feb 10, 2026
View reviewed changes
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What you show in the PR description looks good. I won't pretend to know for sure all the possibly effects of this tag, the query metadata doc page doesn't shed any light, I suggest we go ahead with the change and just keep an eye on things after it is merged.

rust/ql/src/queries/summary/SummaryStats.ql
* @kind metric
* @id rust/summary/summary-statistics
* @tags summary
* @tags summary telemetry
Copy link
Contributor

@geoffw0 geoffw0 Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we do the same change to the Swift versions of these queries (that I am generally responsible for) - swift/summary/summary-statistics and swift/summary/query-sinks at least.

Copy link
Contributor Author

@hvitved hvitved Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would prefer doing that on a separate PR.

@hvitved hvitved merged commit 8955fd0 into github:main Feb 10, 2026
28 checks passed
@hvitved hvitved deleted the rust/add-telemetry-tags branch February 10, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@geoffw0 geoffw0 geoffw0 approved these changes

Assignees

No one assigned

Labels

no-change-note-required This PR does not need a change note Rust Pull requests that update Rust code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hvitved @geoffw0